jpountz commented on a change in pull request #927: LUCENE-8997: : Add type of 
triangle info to ShapeField encoding
URL: https://github.com/apache/lucene-solr/pull/927#discussion_r346564941
 
 

 ##########
 File path: lucene/sandbox/src/java/org/apache/lucene/document/ShapeField.java
 ##########
 @@ -101,21 +143,95 @@ protected void setTriangleValue(int aX, int aY, boolean 
abFromShape, int bX, int
   private static final int MAXY_MINX_MINY_X_Y_MAXX = 6;
   private static final int MINY_MINX_Y_MAXX_MAXY_X = 7;
 
 Review comment:
   What would be the pros/cons vs. adding new triangle types, e.g. as below?
   
   ```
   private static final int POINT_Y_X = 8;
   private static final int LINE_MAXY_MINX_MINY_MAXX = 9;
   private static final int LINE_MINY_MINX_MAXY_MAXX = 10;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to