gus-asf commented on issue #889: LUCENE-8983: Add PhraseWildcardQuery to 
control multi-terms expansions in a phrase
URL: https://github.com/apache/lucene-solr/pull/889#issuecomment-554397677
 
 
   Would the getTermsEnum(Terms) method **really** need to be final when it 
goes to public? Maybe it does, I'm not expert in this protion of the code (just 
happened to stumble into this ticket and read because I was curious), but often 
final methods cause later pain for someone trying to do something nifty. Maybe 
javadocs should say what's important about it being final so others don't 
remove it later when it gets in the way of something (or at least account for 
the potential problems when they do)? Also the sentiment above that the 
protected method shouldn't be called even when it's allowed by java should also 
be in the javadocs for that method. The overall gripe against java for not 
having a feature to enforce the convention you specify I share (this lack was 
actually my very first thought the first time I read about the modifiers in a 
book about java many years ago!), but there's no way for someone else to know 
that the authors are relying on that convention. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to