romseygeek commented on a change in pull request #1011: LUCENE-9031: Just highlight term intervals and its' combinations. URL: https://github.com/apache/lucene-solr/pull/1011#discussion_r346893718
########## File path: lucene/queries/src/java/org/apache/lucene/queries/intervals/TermIntervalsSource.java ########## @@ -149,10 +150,17 @@ public MatchesIterator matches(String field, LeafReaderContext ctx, int doc) thr if (te.seekExact(term) == false) { return null; } - return matches(te, doc); + final TermQuery query; + final TermQuery cached = matchingQuery; + if (cached==null || !field.equals(cached.getTerm().field())) { + matchingQuery = query = new TermQuery(new Term(field, term)); + } else { + query = cached; + } + return matches(te, doc, query); } - static MatchesIterator matches(TermsEnum te, int doc) throws IOException { + static MatchesIterator matches(TermsEnum te, int doc, final Query query ) throws IOException { Review comment: ```suggestion static MatchesIterator matches(TermsEnum te, int doc, String field) throws IOException { TermQuery query = new TermQuery(new Term(field, te.term())); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org