[
https://issues.apache.org/jira/browse/SOLR-13938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975775#comment-16975775
]
Erick Erickson commented on SOLR-13938:
---------------------------------------
What's not at all clear to me is _why_ lucene.txt needs to exist in both
places. What's the point if copying it from
./lucene/tools/forbiddenApis/lucene.txt
to
./buildSrc/src/main/resources/forbidden/lucene.txt
?
This has nothing to do with the ant build unless you're saying we can remove
./lucene/tools/forbiddenApis as part of nuking the ant build. Currently
"lucene.txt" is in Git in both of those places without any means of
coordinating them.
> Make buildSrc not so trappy for the Gradle build
> ------------------------------------------------
>
> Key: SOLR-13938
> URL: https://issues.apache.org/jira/browse/SOLR-13938
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Environment: Just spent a couple of hours trying to figure out why my
> latest attempt to merge master into the gradle build failed with a precommit
> warning about
> {code}
> Forbidden method invocation: java.lang.Math#toRadians(double) [Use home-grown
> methods instead]
> in org.apache.lucene.geo.Rectangle (Rectangle.java:155)
> {code}
> It turns out that we keep copies of "shared"(?) resources in buildSrc,
> specifically in this case there are now two copies of some files in Git, in
> this case:
> ./lucene/tools/forbiddenApis/lucene.txt
> ./buildSrc/src/main/resources/forbidden/lucene.txt
> This one was recently changed to remove a couple of entries on master:
> ./lucene/tools/forbiddenApis/lucene.txt
> But this one is unchanged:
> ./buildSrc/src/main/resources/forbidden/lucene.txt
> I can find no targets that update this automagically.
> Reporter: Erick Erickson
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
