[
https://issues.apache.org/jira/browse/SOLR-13905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975797#comment-16975797
]
Jan Høydahl commented on SOLR-13905:
------------------------------------
{quote}What is exactly the difference?
{quote}
In our tests the /admin/info path (example) comes in pathInfo, while in
production this returns null and we have to pull it from getContextPath or
getServletPath instead. You see similar code in SolrDispatchFilter
[https://github.com/apache/lucene-solr/blob/f07998fc234c81ff956a84ee508b85f8d573ef38/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java#L494-L499]
where we have some null checks.
I propose we create some static utility method
{{SolrUtils.getPathFromRequest()}} to unify this across the code base, probably
everywhere our code tries to call {{HttpServletRequest.getPathInfo()}}?
> Nullpointer exception in AuditEvent
> -----------------------------------
>
> Key: SOLR-13905
> URL: https://issues.apache.org/jira/browse/SOLR-13905
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Auditlogging
> Affects Versions: 8.3
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Priority: Major
> Fix For: 8.4, 8.3.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Nullpointer exception in AuditEvent for events with HttpServletRequest as
> input. Happens when {{getPathInfo()}} returns null, which was not caught by
> current tests. This causes the whole request to fail, rendering the audit
> service unusable.
> The nullpointer is experienced in the {{findRequestType()}} method when
> performing pattern match on the resource (path).
> This is a regression from 8.3, caused by SOLR-13835 where we switched from
> fetching the URL path from {{httpRequest.getContextPath()}} to
> {{httpRequest.getPathInfo()}}. However while this method behaves well in
> tests (JettyTestRunner) it returns {{null}} in production.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
