[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated SOLR-13939: ---------------------------------- Attachment: eoe_merged.patch Status: Open (was: Open) I was also playing around with this today just to get a feel for it. I merged the gradle branch into master then deleted all the changes I could find quickly that mentioned gradle or buildSrc or... (IntelliJ makes this easy by grouping changes by directory). Then I did a quick triage of the changes and saw the same patterns you did. Lots of changes around deprecations, static import changes, some formatting changes to comments etc. The patch attached that's nothing more than an exploratory data point, definitely has cruft in it. In particular, HTMLStripCharFilter.java was regenerated due to a very small change in HTMLStripCharFilter.jflex that I haven't explored. That's in the patch, bloating it a _lot_. On a quick inspection, though, other than the above, I saw couple of other things: - SolrIgnoredThreadsFilter has been added to a number of tests. IDK the purpose, each one needs to be examined. There aren't very many of these though. - TestVirtualMethod was removed, IDK why. It took very little time to get precommit and test to run successfully so that was encouraging, and I could at least fire up the techproducts Solr example. Other than that, though, I've done nothing to verify the correctness of the overall patch but being able to get this far in an hour or so of effort is encouraging. Mostly I was after a read on whether it'd be a horrible thing or not. We're still talking 330 files or so though. Most of them I think are a couple of minutes each, but how to coordinate? > Extract any non-gradle related patches (deprecations, URL fixes, etc.) from > gradle effort > ----------------------------------------------------------------------------------------- > > Key: SOLR-13939 > URL: https://issues.apache.org/jira/browse/SOLR-13939 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Dawid Weiss > Priority: Major > Attachments: SOLR-13939.patch, eoe_merged.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org