romseygeek commented on a change in pull request #1037: LUCENE-9062:
QueryVisitor.consumeTermsMatching
URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350635202
##########
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/FieldOffsetStrategy.java
##########
@@ -192,7 +193,7 @@ protected void createOffsetsEnumsForAutomata(Terms
termsIndex, int doc, List<Off
}
for (int i = 0; i < automata.length; i++) {
- CharacterRunAutomaton automaton = automata[i];
+ CharArrayMatcher automaton = automata[i];
Review comment:
I added a new highlighter class, `LabelledCharArrayMatcher`, with a static
`wrap` method taking a plain matcher, and cut things over to use that. So far
it's only the unified highlighter that actually needs the label, so I think
this puts concerns in the right place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
