dsmiley commented on a change in pull request #442: Fixing an edge case bug
when overriding a default PostingsSolrHighligher
URL: https://github.com/apache/lucene-solr/pull/442#discussion_r351304611
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java
##########
@@ -189,7 +189,7 @@ protected SolrHighlighter getHighlighter(SolrParams
params) {
switch (method) {
case UNIFIED:
- if (solrConfigHighlighter instanceof UnifiedSolrHighlighter) {
+ if (solrConfigHighlighter.getClass() == UnifiedSolrHighlighter.class) {
Review comment:
We must allow users to subclass UnifiedSolrHighlighter. The solution to the
conundrum here is to check that the class _also_ NOT a subclass of the
PostingsSolrHighlighter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
