[
https://issues.apache.org/jira/browse/SOLR-14026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993482#comment-16993482
]
Andrzej Bialecki edited comment on SOLR-14026 at 12/11/19 12:32 PM:
--------------------------------------------------------------------
{quote}According to the DropWizard docs only one MetricsReporter should be
necessary per application
{quote}
Eh, not in our case, since we support different reporting mechanisms and
different contexts (jvm, node, core, etc). We also never reset the stats on
reading so it's totally safe to have more than 1 reporter accessing the same
registry.
Here we should simply pass {{metricManager.registry(registryName)}} to the
super constructor. This registry won't be used by this class anyway, because we
override the only method that uses it and instead we call the delegate.
was (Author: ab):
We should simply pass {{metricManager.registry(registryName)}} to the super
constructor. This registry won't be used by this class anyway, because we
override the only method that uses it and instead we call the delegate.
> Upgrade Jetty to 9.4.24.v20191120 and dropwizard to 4.1.2
> ---------------------------------------------------------
>
> Key: SOLR-14026
> URL: https://issues.apache.org/jira/browse/SOLR-14026
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-14026.patch
>
>
> Prompted by the linked JIRA.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
