[ 
https://issues.apache.org/jira/browse/LUCENE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993538#comment-16993538
 ] 

Robert Muir commented on LUCENE-9079:
-------------------------------------

Uwe filed a JDK bug: https://bugs.openjdk.java.net/browse/JDK-8235668

The issue is that hunspell test files here have "noeol" (meaning EOF, without a 
final EOL before it). So if you look at broken.aff in github or vim, or your 
IDE you'll see 24 lines. But if you run {{wc -l}} it will report only 23, 
because there are really only that many newlines.

With previous JDK, they'd count like {{vim}} (the EOF would "count"), with this 
EA JDK, they count like {{wc -l}}.

I think we could add the missing EOL marker to these files and then these tests 
will shut up about it?

> TestDictionary.testInvalidData fails
> ------------------------------------
>
>                 Key: LUCENE-9079
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9079
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Mikhail Khludnev
>            Priority: Major
>
> eg [https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Linux/1566/consoleText]
> It seems it fails regularly. [~rcmuir] came up with a clue 
> {quote}The test expects a ParseException (which contains offset) to be 
> triggered for the invalid data.
> But the offset isn't what the test expects.
> If you look at the test and the code, there isn't anything sneaky going on 
> here. We just populate the ParseException with getLineNumber.
> Does this only fail with EA JDK? Could be a JDK issue!{quote}
> {{ NOTE: reproduce with: ant test  -Dtestcase=TestDictionary 
> -Dtests.method=testInvalidData -Dtests.seed=89954FC6F33225B1 
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.badapples=true 
> -Dtests.locale=os-GE -Dtests.timezone=Pacific/Guadalcanal 
> -Dtests.asserts=true -Dtests.file.encoding=US-ASCII}}
> {{   [junit4] FAILURE 0.04s J2 | TestDictionary.testInvalidData <<<
>    [junit4]    > Throwable #1: java.lang.AssertionError: expected:<24> but 
> was:<23>
>    [junit4]    >        at 
> __randomizedtesting.SeedInfo.seed([89954FC6F33225B1:61632831A7F4F9CE]:0)
>    [junit4]    >        at 
> org.apache.lucene.analysis.hunspell.TestDictionary.testInvalidData(TestDictionary.java:137)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to