dweiss commented on a change in pull request #1076: SOLR-14048: Improve Hadoop
test sanity checks
URL: https://github.com/apache/lucene-solr/pull/1076#discussion_r357224018
##########
File path: solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsTestUtil.java
##########
@@ -87,6 +99,23 @@ private static void checkHadoopWindows() {
!Constants.WINDOWS || NativeIO.isAvailable());
}
+ /**
+ * Ensure that the tests are picking up the modified Hadoop classes
+ */
+ private static void checkOverriddenHadoopClasses() {
+ List<Class<?>> modifiedHadoopClasses = Arrays.asList(BlockPoolSlice.class,
DiskChecker.class,
Review comment:
A field is fine, sure. I just though it'd be more elegant to keep it in one
place :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
