dweiss commented on issue #1138: LUCENE-9077 Print repro line for failed tests
URL: https://github.com/apache/lucene-solr/pull/1138#issuecomment-570797460
 
 
   Hi Mike. I looked at gradle's internal APIs again and I don't think we'll be 
able to dodge having a custom test output listener. I would rather have it 
complete two goals at once: emit test failure information and dump test output 
on failure.
   
   This has been done by Elasticsearch under this issue: 
https://github.com/elastic/elasticsearch/issues/31496 
   
   The discussion there is enlightening about certain aspects of handling 
gradle's output. We can also borrow some of the code (like 
ErrorReportingTestListener.java that buffers up test output and discards it if 
the test passes). I believe some changes would have to be implemented -- Solr 
tests emit *TONS* of output and it will lead to OOM exceptions of the build 
system... It should spill to disk after it reaches a certain threshold. But 
even the in-memory version would be a start.
   
   Would you be willing to bite into this (borrowing some code from ES)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to