MarcusSorealheis commented on a change in pull request #1141: SOLR-14147 change 
the Security manager to default to true.
URL: https://github.com/apache/lucene-solr/pull/1141#discussion_r363077409
 
 

 ##########
 File path: solr/solr-ref-guide/src/securing-solr.adoc
 ##########
 @@ -97,4 +97,4 @@ It is also strongly recommended that Solr listen to only 
those network interface
 
 == Enable Security Manager
 
-Solr can run in a Java Security Manager sandbox by setting 
`SOLR_SECURITY_MANAGER_ENABLED=true` via environment variable or in 
`solr.in.sh`/`solr.in.cmd`. This feature is incompatible with Hadoop.
+Solr runs in a Java Security Manager sandbox by default. Since this feature is 
incompatible with Hadoop, you can disable it by setting 
`SOLR_SECURITY_MANAGER_ENABLED=false` via environment variable or in 
`solr.in.sh`/`solr.in.cmd` if you are running Solr with Hadoop.
 
 Review comment:
   I will take a look and add it to the PR. Since the default is true, I do 
agree that the Hadoop bit should be on its own. This comment makes me want to 
test to see if the security manager is still incompatible with Hadoop. I don't 
know enough of the history to know if it should or should not work. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to