mbwaheed commented on a change in pull request #1131: SOLR-14134: Add lazy and
time-based evictiction of shared core concurrency metada…
URL: https://github.com/apache/lucene-solr/pull/1131#discussion_r364511371
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -1191,9 +1192,11 @@ protected SolrCore registerCore(CoreDescriptor cd,
SolrCore core, boolean regist
* set both the name of the descriptor and the name of the
* core, since the descriptors name is used for persisting.
*/
-
core.setName(cd.getName());
-
+
+ // Check and evict any pre-existing concurrency metadata for cores
belonging to shared replicas
+ evictSharedCoreMetadata(cd);
Review comment:
This call is not exclusive to cloud mode(zkSys.getZkController() != null).
Inside evictShareCoreMetadata, getSharedStoreManager() can be null. Need
zkSys.getZkController() != null protection here or inside
evictShareCoreMetadata. I would put it inside the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
