kaivalnp commented on code in PR #16723:
URL: https://github.com/apache/lucene/pull/16723#discussion_r4353422501
##########
.github/workflows/run-special-checks-sandbox.yml:
##########
@@ -66,6 +66,12 @@ jobs:
- name: Prepare Lucene workspace
uses: ./.github/actions/prepare-for-build
+ - name: Prepare AVX2 Faiss C library
+ run: |
+ cp "$CONDA_PREFIX/lib/libfaiss_c.so"
"$CONDA_PREFIX/lib/libfaiss_c_avx2.so"
+ patchelf --replace-needed libfaiss.so libfaiss_avx2.so
"$CONDA_PREFIX/lib/libfaiss_c_avx2.so"
Review Comment:
My bad: I realized I had added a change in Faiss to publish the C library
(including SIMD variants) to Conda
(https://github.com/facebookresearch/faiss/pull/4186).
I installed `faiss-cpu=1.11.0` from Conda on `aarch64` and `x86_64` hosts,
and I see the following artifacts:
```
aarch64: libfaiss_c.so, libfaiss_c_sve.so
```
```
x86_64: libfaiss_c.so, libfaiss_c_avx2.so, libfaiss_c_avx512.so
```
I don't think we need this step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
