jimczi commented on PR #16883: URL: https://github.com/apache/lucene/pull/16883#issuecomment-6361825843
@ChrisHegarty as we discussed offline, updateIOContext is the wrong way to do this. It changes the advice of pages shared by every clone and slice, so I made it a no-op on mmap. Nothing calls it anyway. That simplifies the branch a lot: an input keeps the advice it was opened or sliced with, and the field is final, so there's no shared state and no race. I'll deprecate it in a follow up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
