ChrisHegarty commented on PR #16945: URL: https://github.com/apache/lucene/pull/16945#issuecomment-6496669559
> Looks fine. The attachment code is not so nice. Interesting to me is that the type system of Java 21 allows that the "if not" with cast to new variable name in the if condition can be used AFTER the if.... cool. > > I thought you can only use the variables introducted by the cast in the "then" so it needs to be a positive instanceof check. Something new every day! ha! yeah. I remember being surprise the first time I learned abut this. It is pretty cool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
