javanna commented on code in PR #16942:
URL: https://github.com/apache/lucene/pull/16942#discussion_r4410926802
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##########
@@ -288,6 +289,10 @@ public static Iterable<Object[]>
allInitialMajorVersion(String name, String... s
List<Object[]> versionAndPatterns = new ArrayList<>();
for (Version v : versions) {
+ if (v.equals(LATEST_PREVIOUS_MAJOR)) {
Review Comment:
This is to cover the scenario that we are in now: 11.0 is not released yet,
hence we have no 11.0 indices checked in. But that's ok, as 11.0 is the latest
previous major, which is not supposed to be released. This will change once
11.0 is released and 11.1 will move to be the latest previous major under
development.
Does this make sense to you @romseygeek ? Pinging given you already reviewed
this PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
