slow-J commented on PR #16790: URL: https://github.com/apache/lucene/pull/16790#issuecomment-6524921967
Thanks for the review @kaivalnp ! Publishing a new commit shortly addressing most comments, will come back to the Welford's algorithm one. Re-ran JMH too and it looks more performant with your input. `scalarQuantizeVector`: ops/ms, main f7bcc0abd8 -> this PR | size | main | this PR | ratio | |---:|---:|---:|---:| | 384 | 41.126 ± 1.232 | 375.719 ± 8.801 | 9.14x | | 768 | 19.121 ± 0.617 | 185.526 ± 3.898 | 9.70x | | 1024 | 13.892 ± 0.402 | 137.864 ± 3.340 | 9.92x | | 4096 | 3.144 ± 0.091 | 33.293 ± 0.624 | 10.59x | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
