gsmiller commented on PR #16145: URL: https://github.com/apache/lucene/pull/16145#issuecomment-6802787639
In an effort to avoid "analysis paralysis," I think it's reasonable to go with 256 based on all the evidence here. Tuning a constant like this is challenging given all the different deployment environments, workloads, etc. that can behave differently. We can follow up with a different paradigm that can self-adjust better if necessary (e.g., maybe `getrusage`, etc.) or potentially open up extensibility for advanced users that really want tight tuning control of this in their environment. Shall we set SKIP to 256 and get this merged for the 11.0 release? I'll plan to merge on Friday if nobody raises a concern with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
