gerlowskija opened a new pull request #1162: SOLR-14186: Re-add CRLF line endings to solr.cmd URL: https://github.com/apache/lucene-solr/pull/1162 # Description solr.cmd needs CRLF endings, but they were stripped out in a recent commit. # Solution I ran unix2dos to convert the file back to CRLF endings (and temporarily disabled my `autocrlf` setting so this change would actually get persisted on commit). Shortly we need to add a `.gitattributes` file so that this doesn't happen again, but I want to get Windows devs/users unblocked while review of that happens separately. # Tests N/A, whitespace changes only. Though I did play with bin/solr.cmd a bit to make sure that the "labels" can be found with these new line endings. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [X] I have developed this patch against the `master` branch. - [X] I have run `ant precommit` and the appropriate test suite. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
