[ https://issues.apache.org/jira/browse/SOLR-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014629#comment-17014629 ]
David Smiley commented on SOLR-14185: ------------------------------------- On second thought this method could be named simply {{iterator}} which might be a more intuitive a name. There's already a no-arg version already exists although it returns a Solr {{DocIterator}} (not {{DocIdSetIterator}}). DocIterator is another old abstraction that not only returns docs but scores too. But a DocSet doesn't have scores; I would rather DocSet only return a DocIdSetIterator. That's a separate issue. Any way, the proposed method here can be named {{iterator}}. > add DocSet.getDocIdSetIterator(LeafReaderContext) > ------------------------------------------------- > > Key: SOLR-14185 > URL: https://issues.apache.org/jira/browse/SOLR-14185 > Project: Solr > Issue Type: Sub-task > Reporter: David Smiley > Priority: Major > > Many callers of {{DocSet.getTopFilter()}} really just want to call > {{getDocIdSet}} on the Filter and then call {{iterator()}}. The Bits 2nd arg > is also always null or always live-docs so this arg doesn't matter since a > Solr DocSet never contains deleted docs. The goal here is to reduce needless > dependencies on the old Filter. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org