gerlowskija opened a new pull request #1171: SOLR-13892: Add 'top-level' 
docValues Join implementation
   # Description
   Some join usecases are better served (performance wise) by using top-level 
docValues structures, because they avoid some wasteful seeking and iteration 
that the per-segment alternatives do.
   # Solution
   This PR introduces a "TopLevelJoinQuery" which can be run on join's where 
the fields in question have docValues enabled.  This scales much better with 
the number of "from" query matches than existing alternatives.  Since it's 
implemented as a Two-Phase Iterator it scales less well by the number of 
overall matches.  See SOLR-13892 for more in-depth performance discussion.
   # Tests
   Beefed up tests in `TestJoin` to prove correctness.  Wrote a performance 
test driver `TestJoinQueryPerformance` that allows reproduction of the perf 
results.  (Though this will not be committed in the final version) 
   # Checklist
   Please review the following and check all that apply:
   - [x] I have reviewed the guidelines for [How to 
Contribute]( and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
   - [x] I have given Solr maintainers 
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `ant precommit` and the appropriate test suite.
   - [x] I have added tests for my changes.
   - [x] I have added documentation for the [Ref 
(for Solr changes only).

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to