irvingzhang commented on a change in pull request #1169: LUCENE-9004: A minor feature and patch -- support deleting vector values and fix segments merging URL: https://github.com/apache/lucene-solr/pull/1169#discussion_r368235896
########## File path: lucene/core/src/java/org/apache/lucene/search/KnnExactDeletionCondition.java ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.search; + +import java.io.IOException; + +/** + * A query for deleting the exact values of the specified querying vector, used for + * {@link org.apache.lucene.index.IndexWriter#deleteDocuments(Query...)}. + */ +public class KnnExactDeletionCondition extends KnnGraphQuery { Review comment: Yes, your understanding is correct and highly appreciated. 1. The class KnnExactVectorValueQuery (revised name) is originally designed for deleting vectors by query. When we are going to delete some vector by its exact values, Lucene seems to retrieve all the similar vectors and then delete all of them, which may not be the behavior we expect. The class KnnExactVectorValueWeight is the corresponding weight for KnnExactVectorValueQuery to filter the vectors that not exactly equal to the query vector. Therefore, the two classes are specially designed for deletion. The results that KnnGraphQuery retrieved contains that of KnnExactVectorValueWeight retrieved, so there's any requirement to establish a new query type (e.g. KnnExactVectorValueQuery) for ordinary query. 2. I'm not pretty sure if there is any situation that we need to delete by query. So I moved both classes into my test case. Now, there isn't any new feature, just some minor bug fix. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
