[
https://issues.apache.org/jira/browse/LUCENE-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020565#comment-17020565
]
Uwe Schindler commented on LUCENE-9158:
---------------------------------------
The patch has one problem. The whole work folder is deleted, if the junit task
succeeds. This is normally fine, but if you enable the mode to not fail build
if tests fail (e.g. on CI like Jenkins), the directory is still removed.
Please remove at least the delete task and restore previous state. The test
runner tries to cleanup anyways.
I'd suggest to add a root task to clean test outputs.
In addition, I would prefer to have a tempdir name that contains done hash of
common.dir. this is more CI friendly. The current patch breaks if you run tests
in 2 checkouts in parallel (like run 8.x and master in 2 terminals).
> Fix tests to respect java.io.tmpdir by default
> ----------------------------------------------
>
> Key: LUCENE-9158
> URL: https://issues.apache.org/jira/browse/LUCENE-9158
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/test
> Reporter: Robert Muir
> Priority: Major
> Attachments: LUCENE-9158.patch
>
>
> Currently the tests destroy your SSDs by writing temp test data to
> {{build/test/}} in your checkout.
> It would be better to respect {{java.io.tmpdir}} for where all the temporary
> files get written. This way, if someone has configured their
> system/environment variables appropriately, it won't destroy SSD.
> On linux it may work by default in many cases, as a lot of linux systems
> mount {{/tmp}} on tmpfs by default.
> On windows users could have created a [RAM
> drive|https://en.wikipedia.org/wiki/List_of_RAM_drive_software] such as
> {{R:}} and have {{TMP}} environment variable pointed at it, we should respect
> that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
