dweiss commented on issue #1199: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1199#issuecomment-578532163 This is great work, Erick and is very much appreciated. I do have a "but" though -- it's large and goes through a number of those tasks at once. I'm sorry I've been slow in taking in your patches. I can't really find a chunk of time large enough to review and correct certain issues in a large patch like this one. I'd really like to have minimalistic build fragments that only deal with one thing at a time. It's different from ant (and arguably different from how other projects structure gradle builds) but to me it makes reasoning about a particular build aspect simpler. Take jflex for example as it is really self-contained. You need to have access to jflex at a given version (no need to download anything -- you just declare a configuration and a dependency), you need a top-level task (so that it shows up in help) and you need to configure tasks that are attached to it in each project where we generate stuff from jflex files. I just committed an example that regenerates StandardTokenizerImpl in lucene/core - please take a look at the sources and see if it matches what I tried to express above. When you run "gradlew jflex" it'll recreate StandardTokenizerImpl.java... in fact when you run git diff you won't even see the difference because the regenerated file is identical to what it was before (which I think should be an ideal goal for now because we don't want to generate stuff other than ant does). The remaining jflex regeneration targets can be appended to this file, making it a clean, single-objective concern. When or if at some point somebody decides that a different way to deal with jflex files is more attractive (for example use an external plugin or move the custom task to buildSrc) those changes remain pretty much local to this file.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
