[
https://issues.apache.org/jira/browse/LUCENE-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026420#comment-17026420
]
Erick Erickson commented on LUCENE-9134:
----------------------------------------
[~dweiss] [~mdrob]
Getting closer. Here's the current state:
I've got all the cleanup in place, it's just tedious. Gradle precommit and
assemble pass, the assemble without warnings. I strayed a little bit and
cleaned up some of the casts in the code, but that means there aren't any
"SuppressWarnings" that need to be added any more. There are deprecation
warnings if I specify to look for them, but that's such a mess with FuzzyQuery
that I'm not touching that.
I'm running the gradle "build" target to run tests tonight, it's late. Before I
put in a PR, I want to try precommit and test under Ant, since there are some
changes to the java files, but frankly very few. If all goes well that'll be
tomorrow by noon my time (UTC - 5).
------
I noticed that Dawid redirected stdout and stderr to a local bytestream in
javacc.gradle, which avoids the unsettling "generating new....." messages.
Clever!
{code:java}
def output = new ByteArrayOutputStream()
.
.
.
standardOutput = output
errorOutput = output
{code}
WDYT about just redirecting standardOutput? In a successful run just
redirecting standardOutput is identical to redirecting both, I think there's
value in seeing the error output if there is any...
----
One other thing, anticipating the next bit: I haven't looked at the python
generation yet, but off the top of your head do you think they should follow
the same pattern? Something like a sibling file to javacc.gradle? Or some other
pattern? Once I learn one trick, it's all I do ;)
> Port ant-regenerate tasks to Gradle build
> -----------------------------------------
>
> Key: LUCENE-9134
> URL: https://issues.apache.org/jira/browse/LUCENE-9134
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: LUCENE-9134.patch, core_regen.patch
>
> Time Spent: 10h
> Remaining Estimate: 0h
>
> Take II about organizing this beast.
> A list of items that needs to be added or requires work. If you'd like to
> work on any of these, please add your name to the list. See process comments
> at parent (LUCENE-9077)
> * Implement jflex task in lucene/core
> * Implement jflex tasks in lucene/analysis
> * Implement javacc tasks in lucene/queryparser (EOE)
> * Implement javacc tasks in solr/core (EOE)
> * Implement python tasks in lucene (? there are several javadocs mentions in
> the build.xml, this may be irrelevant to the Gradle effort).
> * Implement python tasks in lucene/core
> * Implement python tasks in lucene/analysis
>
> Here are the "regenerate" targets I found in the ant version. There are a
> couple that I don't have evidence for or against being rebuilt
> // Very top level
> {code:java}
> ./build.xml: <target name="regenerate" description="Runs all code
> regenerators">
> ./build.xml: <subant target="regenerate" inheritall="false"
> failonerror="true">
> ./build.xml: <target name="regenerateAndCheck"
> depends="regenerate,-check-after-regeneration"/>
> {code}
> // top level Lucene. This includes the core/build.xml and
> test-framework/build.xml files
> {code:java}
> ./lucene/build.xml: <target name="regenerate">
> ./lucene/build.xml: <subant target="regenerate" failonerror="true"
> inheritall="false">
> ./lucene/build.xml: <modules-crawl target="regenerate"/>
> {code}
> // This one has quite a number of customizations to
> {code:java}
> ./lucene/core/build.xml: <target name="regenerate"
> depends="createLevAutomata,createPackedIntSources,jflex"/>
> {code}
> // This one has a bunch of code modifications _after_ javacc is run on
> certain of the
> // output files. Save this one for last?
> {code:java}
> ./lucene/queryparser/build.xml: <target name="regenerate" depends="javacc"/>
> {code}
> // the files under ../lucene/analysis... are pretty self contained. I expect
> these could be done as a unit
> {code:java}
> ./lucene/analysis/build.xml: <target name="regenerate">
> ./lucene/analysis/build.xml: <forall-analyzers target="regenerate"/>
> ./lucene/analysis/common/build.xml: <target name="regenerate"
> depends="jflex,unicode-data"/>
> ./lucene/analysis/icu/build.xml: <target name="regenerate"
> depends="gen-utr30-data-files,gennorm2,genrbbi"/>
> ./lucene/analysis/kuromoji/build.xml: <target name="regenerate"
> depends="build-dict"/>
> ./lucene/analysis/nori/build.xml: <target name="regenerate"
> depends="build-dict"/>
> ./lucene/analysis/opennlp/build.xml: <target name="regenerate"
> depends="train-test-models"/>
> {code}
>
> // These _are_ regenerated from the top-level regenerate target, but for –
> LUCENE-9080//the changes were only in imports so there are no
> //corresponding files checked in in that JIRA
> {code:java}
> ./lucene/expressions/build.xml: <target name="regenerate"
> depends="run-antlr"/>
> {code}
> // Apparently unrelated to ./lucene/analysis/opennlp/build.xml
> "train-test-models" target
> // Apparently not rebuilt from the top level, but _are_ regenerated when
> executed from
> // ./solr/contrib/langid
> {code:java}
> ./solr/contrib/langid/build.xml: <target name="regenerate"
> depends="train-test-models"/>
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
