andyvuong commented on a change in pull request #1223: SOLR-14213: Configuring 
Solr Cloud to use Shared Storage
URL: https://github.com/apache/lucene-solr/pull/1223#discussion_r373634692
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
 ##########
 @@ -756,6 +763,12 @@ public void load() {
         // is set to true for them
         // TODO: should this go behind some config?
         List<CoreDescriptor> additionalCoreDescriptors = 
discoverAdditionalCoreDescriptorsForSharedReplicas(cds);
+        if (!isSharedStoreEnabled() && discoveredSharedCollection) {
+          throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, 
 
 Review comment:
   This doesn't actually stop the process from starting up and currently not 
sure of a good way to abort the process if it's misconfigured. There used to be 
a setting by that was deprecated a long time ago.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to