andyvuong opened a new pull request #1238: SOLR-14240: Clean up znodes after shard deletion is invoked URL: https://github.com/apache/lucene-solr/pull/1238 # Description Delete left over znodes on zookeeper that aren't removed after a delete shard command is issued. # Solution In DeleteShardCmd, use the zk client to issue a recursive delete from the specified root and its children (including that root). # Tests Added assertions to DeleteShardTest to verify the znodes no longer exist. Ran the full test suite via `ant test` and finally did a manual test via the same steps described in the jira description. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [x] I have run `ant precommit` and the appropriate test suite. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
