[ 
https://issues.apache.org/jira/browse/SOLR-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated SOLR-14194:
--------------------------------
    Attachment: SOLR-14194.patch
        Status: Patch Available  (was: Patch Available)

I applied the patch and worked with it a bit more.  You were calling a 
deprecated method (IntelliJ showed this plainly) and one thing led to another 
with some improvements.  It should now be the case that the original 
Highlighter can highlight text from DocValues.

There's a back-compat break for anyone subclassing the DefaultSolrHighlighter 
due to Document->SolrDocument but we have no guarantees on that and users can 
fork or adapt as they wish.

> Allow Highlighting to work for indexes with uniqueKey that is not stored
> ------------------------------------------------------------------------
>
>                 Key: SOLR-14194
>                 URL: https://issues.apache.org/jira/browse/SOLR-14194
>             Project: Solr
>          Issue Type: Improvement
>          Components: highlighter
>    Affects Versions: master (9.0)
>            Reporter: Andrzej Wislowski
>            Assignee: David Smiley
>            Priority: Minor
>              Labels: highlighter
>         Attachments: SOLR-14194.patch, SOLR-14194.patch, SOLR-14194.patch
>
>
> Highlighting requires uniqueKey to be a stored field. I have changed 
> Highlighter allow returning results on indexes with uniqueKey that is a not 
> stored field, but saved as a docvalue type.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to