dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym
Queries boost
URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376754130
##########
File path:
lucene/core/src/java/org/apache/lucene/util/graph/GraphTokenStreamFiniteStrings.java
##########
@@ -124,6 +126,15 @@ public boolean hasSidePath(int state) {
.toArray(Term[]::new);
}
+ /**
+ * Returns the list of terms that start at the provided state
+ */
+ public QueryBuilder.TermAndBoost[] getTermsAndBoosts(String field, int
state) {
Review comment:
Given that this class, GraphTokenStreamFiniteStrings deals with
List<AttributeSource> (something I did not know when I made a previous
comment), and also that TermAndBoost is an inner class to QueryBuilder, I think
it's better to put this back into QueryBuilder. I still think
`List<AttributeSource>` is weird and heavyweight but you didn't add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
