[ 
https://issues.apache.org/jira/browse/SOLR-13996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033687#comment-17033687
 ] 

ASF subversion and git services commented on SOLR-13996:
--------------------------------------------------------

Commit 78e567c57e45f56ff22ecfc3e43e315255ef3561 in lucene-solr's branch 
refs/heads/branch_8x from Shalin Shekhar Mangar
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=78e567c ]

SOLR-13996: Refactor HttpShardHandler.prepDistributed method (#1220)

SOLR-13996: Refactor HttpShardHandler.prepDistributed method into smaller pieces

This commit introduces an interface named ReplicaSource which is marked as 
experimental. It has two sub-classes named CloudReplicaSource (for solr cloud) 
and LegacyReplicaSource for non-cloud clusters. The prepDistributed method now 
calls out to these sub-classes depending on whether the cluster is running on 
cloud mode or not.

(cherry picked from commit c65b97665c61116632bc93e5f88f84bdb5cccf21)


> Refactor HttpShardHandler#prepDistributed() into smaller pieces
> ---------------------------------------------------------------
>
>                 Key: SOLR-13996
>                 URL: https://issues.apache.org/jira/browse/SOLR-13996
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ishan Chattopadhyaya
>            Assignee: Shalin Shekhar Mangar
>            Priority: Major
>         Attachments: SOLR-13996.patch, SOLR-13996.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently, it is very hard to understand all the various things being done in 
> HttpShardHandler. I'm starting with refactoring the prepDistributed() method 
> to make it easier to grasp. It has standalone and cloud code intertwined, and 
> wanted to cleanly separate them out. Later, we can even have two separate 
> method (for standalone and cloud, each).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to