[ 
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034840#comment-17034840
 ] 

Dawid Weiss commented on LUCENE-9201:
-------------------------------------

Hi [~tomoko]. Please take a look at the patch I just attached. This has the 
structure and logical organisation that Uwe mentioned (tasks created per source 
set, aggregation task ecjLint for each project, etc.) but is still far from 
optimal. In general the task you chose to start from is kind of difficult - 
don't get discouraged! :)

The patch generally compiles the sources via ecj (main source separately from 
test sources; everything with an appropriate set of dependencies). I didn't add 
javadoc-linting options since there are still some problems I couldn't figure 
out (and I need a break now). Namely:

* -nowarn doesn't seem to work; it still displays warnings for me.
* source sets allow individual file exclusions; gradle's javac compiles 
individual java files but the forked process path explodes for ECJ causing an 
error. This is only affecting solr-ref-guide (which I manually disabled) but 
it'd be nice to figure out a way to make it consistent.
* I didn't look into javadoc linting or those options passed to ecj by ant 
(didn't have time).

Would you mind taking another look at this? Does it help anyhow?

> Port documentation-lint task to Gradle build
> --------------------------------------------
>
>                 Key: LUCENE-9201
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9201
>             Project: Lucene - Core
>          Issue Type: Sub-task
>    Affects Versions: master (9.0)
>            Reporter: Tomoko Uchida
>            Assignee: Tomoko Uchida
>            Priority: Major
>         Attachments: LUCENE-9201-ecj.patch, javadocGRADLE.png, 
> javadocHTML4.png, javadocHTML5.png
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Ant build's "documentation-lint" target consists of those two sub targets.
>  * "-ecj-javadoc-lint" (Javadoc linting by ECJ)
>  * "-documentation-lint"(Missing javadocs / broken links check by python 
> scripts)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to