ASF subversion and git services commented on SOLR-14245:

Commit 49e20dbee4b7e74448928a48bfbb50da1018400f in lucene-solr's branch 
refs/heads/master from Chris M. Hostetter
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=49e20db ]

SOLR-14245: Fix ReplicaListTransformerTest

Previous changes to this issue 'fixed' the way the test was creating mock 
Replica instances,
to ensure all properties were specified -- but these changes tickled a bug in 
the existing test
scaffolding that caused it's "expecations" to be based on a regex check against 
only the base "url"
even though the test logic itself looked at the entire "core url"

The result is that there were reproducible failures if/when the randomly 
generated regex matched
".*1.*" because the existing test logic did not expect that to match the url or 
a Replica with
a core name of "core1" because it only considered the base url

> Validate Replica / ReplicaInfo on creation
> ------------------------------------------
>                 Key: SOLR-14245
>                 URL: https://issues.apache.org/jira/browse/SOLR-14245
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>            Reporter: Andrzej Bialecki
>            Assignee: Andrzej Bialecki
>            Priority: Minor
>             Fix For: 8.5
> Replica / ReplicaInfo should be immutable and their fields should be 
> validated on creation.
> Some users reported that very rarely during a failed collection CREATE or 
> DELETE, or when the Overseer task queue becomes corrupted, Solr may write to 
> ZK incomplete replica infos (eg. node_name = null).
> This problem is difficult to reproduce but we should add safeguards anyway to 
> prevent writing such corrupted replica info to ZK.

This message was sent by Atlassian Jira

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to