markharwood commented on a change in pull request #1234: Add compression for
Binary doc value fields
URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379463675
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java
##########
@@ -182,10 +183,21 @@ private BinaryEntry readBinary(ChecksumIndexInput meta)
throws IOException {
entry.numDocsWithField = meta.readInt();
entry.minLength = meta.readInt();
entry.maxLength = meta.readInt();
- if (entry.minLength < entry.maxLength) {
+ if ((version >= Lucene80DocValuesFormat.VERSION_BIN_COMPRESSED &&
entry.numDocsWithField >0)|| entry.minLength < entry.maxLength) {
entry.addressesOffset = meta.readLong();
+
+ // Old count of uncompressed addresses
+ long numAddresses = entry.numDocsWithField + 1L;
+ // New count of compressed addresses - the number of compresseed blocks
+ if (version >= Lucene80DocValuesFormat.VERSION_BIN_COMPRESSED) {
+ entry.numCompressedChunks = meta.readVInt();
+ entry.docsPerChunk = meta.readVInt();
Review comment:
Ah - ignore my previous comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
