[
https://issues.apache.org/jira/browse/SOLR-13794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037193#comment-17037193
]
ASF subversion and git services commented on SOLR-13794:
--------------------------------------------------------
Commit f549ee353530fcd48390a314aff9ec1723b47346 in lucene-solr's branch
refs/heads/master from Chris M. Hostetter
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f549ee3 ]
SOLR-13794: Replace redundent test only copy of '_default' configset with
SolrTestCase logic to correctly set 'solr.default.confdir' system property
This change allows us to remove kludgy test only code from ZkController
> Delete solr/core/src/test-files/solr/configsets/_default
> --------------------------------------------------------
>
> Key: SOLR-13794
> URL: https://issues.apache.org/jira/browse/SOLR-13794
> Project: Solr
> Issue Type: Test
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-13794.patch, SOLR-13794.patch,
> SOLR-13794_code_only.patch, SOLR-13794_code_only.patch
>
>
> For as long as we've had a {{_default}} configset in solr, we've also had a
> copy of that default in {{core/src/test-files/}} - as well as a unit test
> that confirms they are identical.
> It's never really been clear to me *why* we have this duplication, instead of
> just having the test-framework take the necessary steps to ensure that
> {{server/solr/configsets/_default}} is properly used when running tests.
> I'd like to propose we eliminate the duplication since it only ever seems to
> cause problems (notably spurious test failures when people modify the
> {{_default}} configset w/o remembering that they need to make identical edits
> to the {{test-files}} clone) and instead have {{SolrTestCase}} set the
> (already existing & supported) {{solr.default.confdir}} system property to
> point to the (already existing) {{ExternalPaths.DEFAULT_CONFIGSET}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
