shalinmangar commented on a change in pull request #417: Fixes SOLR-12550:
ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize
URL: https://github.com/apache/lucene-solr/pull/417#discussion_r380624225
##########
File path:
solr/solrj/src/test/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClientTest.java
##########
@@ -346,4 +347,25 @@ public OutcomeCountingConcurrentUpdateSolrClient build() {
}
}
}
+
+ /**
+ * Test that connection timeout information is passed to the HttpSolrClient
that handle non add operations
+ */
+ @Test(timeout = 1000)
+ public void testConnectionTimeoutOnCommit() throws IOException,
SolrServerException {
+ // 240.0.0.0/4 is reserved for future use by the IANA and is in effect a
black hole
+ try (ConcurrentUpdateSolrClient client = new
ConcurrentUpdateSolrClient.Builder("http://240.0.0.1:8983/";)
Review comment:
Please use `SolrTestCaseJ4.DEAD_HOST` instead of a real networking address
so that it fails fast. After SOLR-14050, the security policy for tests allows
connections to loopback only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
