[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039137#comment-17039137
]
Tomoko Uchida edited comment on LUCENE-9201 at 2/18/20 2:59 PM:
----------------------------------------------------------------
Yes, the patch works for me too, with this modification. It's not explicitly
documented, but {{sourceSet.getTaskName("ecjLint", null)}} generates
"ecjLintMain" for main sourceSet and "ecjLintTest" for test sourceSet (on
Gradle version 6.0).
{code:java}
//tasks.create("${sourceSet.name}EcjLint", JavaExec, {
tasks.create(sourceSet.getTaskName("ecjLint", null), JavaExec, {
{code}
Can I ask a few more questions before creating a patch?
1. Even when I commented out those lines in gradle.build,
":solr:solr-ref-guide:ecjLint" finished without doing nothing (linting was
safely skipped by the changes in solr/solr-ref-guide/build.gradle, if my
understanding is correct). Is this configuration still needed?
{code:java}
// This excludes solr-ref-guide from the check (excludes are not taken into
account
// and linting of the ant-based task fails.
configure(project(":solr:solr-ref-guide")) {
afterEvaluate {
project.tasks.findByPath("mainEcjLint").enabled = false
}
}
{code}
2. Currently all other check tasks are grouped in "Verification", so would it
be better to change the task group name "validation" to "Verification"?
{code:java}
$ ./gradles tasks
...
Validation tasks
----------------
ecjLint - Lint Java sources using ECJ.
Verification tasks
------------------
check - Runs all checks.
checkUnusedConstraints - Ensures all versions in your versions.props correspond
to an actual gradle dependency
forbiddenApis - Runs forbidden-apis checks.
owasp - Check project dependencies against OWASP vulnerability database.
rat - Runs Apache Rat checks.
test - Runs the unit tests.
verifyLocks - Verifies that your versions.lock is up to date
{code}
was (Author: tomoko uchida):
Yes, the patch works for me too, with this modification. It's not explicitly
documented, but {{sourceSet.getTaskName("ecjLint", null)}} generates
"ecjLintMain" for main sourceSet and "ecjLintTest" for test sourceSet (on
Gradle version 6.0).
{code:java}
//tasks.create("${sourceSet.name}EcjLint", JavaExec, {
tasks.create(sourceSet.getTaskName("ecjLint", null), JavaExec, {
{code}
Can I ask a few questions before creating a patch?
1. When I commented out those lines in gradle.build,
":solr:solr-ref-guide:ecjLint" finished without doing nothing (linting was
safely skipped by the changes in solr/solr-ref-guide/build.gradle, if my
understanding is correct). Is this configuration still needed?
{code:java}
// This excludes solr-ref-guide from the check (excludes are not taken into
account
// and linting of the ant-based task fails.
configure(project(":solr:solr-ref-guide")) {
afterEvaluate {
project.tasks.findByPath("mainEcjLint").enabled = false
}
}
{code}
2. Currently all other check tasks are grouped in "Verification", so would it
be better to change the task group name "validation" to "Verification"?
{code:java}
$ ./gradles tasks
...
Validation tasks
----------------
ecjLint - Lint Java sources using ECJ.
Verification tasks
------------------
check - Runs all checks.
checkUnusedConstraints - Ensures all versions in your versions.props correspond
to an actual gradle dependency
forbiddenApis - Runs forbidden-apis checks.
owasp - Check project dependencies against OWASP vulnerability database.
rat - Runs Apache Rat checks.
test - Runs the unit tests.
verifyLocks - Verifies that your versions.lock is up to date
{code}
> Port documentation-lint task to Gradle build
> --------------------------------------------
>
> Key: LUCENE-9201
> URL: https://issues.apache.org/jira/browse/LUCENE-9201
> Project: Lucene - Core
> Issue Type: Sub-task
> Affects Versions: master (9.0)
> Reporter: Tomoko Uchida
> Assignee: Tomoko Uchida
> Priority: Major
> Attachments: LUCENE-9201-ecj-2.patch, LUCENE-9201-ecj.patch,
> javadocGRADLE.png, javadocHTML4.png, javadocHTML5.png
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Ant build's "documentation-lint" target consists of those two sub targets.
> * "-ecj-javadoc-lint" (Javadoc linting by ECJ)
> * "-documentation-lint"(Missing javadocs / broken links check by python
> scripts)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
