morissm commented on issue #417: Fixes SOLR-12550: ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize URL: https://github.com/apache/lucene-solr/pull/417#issuecomment-587937426 > So I think this is built off of a really old master. We should probably make sure these timeouts are also respected by `ConcurrentUpdateHttp2SolrClient` I took a look at `ConcurrentUpdateHttp2SolrClient` while I was adressing the issues raised by the other reviewers. I have not conducted any tests but I don't think it would exhibit the same issue. Its builder works differently and reuses `UpdateShardHandler`'s httpClient which is correctly configured.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
