CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r381002805
########## File path: solr/solr-ref-guide/src/replica-management.adoc ########## @@ -212,6 +212,11 @@ The number of replicas to remove. If the requested number exceeds the number of + If `replica` is used instead, this parameter is not required. Otherwise, this parameter must be supplied. +`type`:: + +The type of replicas to remove. This parameter compliments `count` parameter. If the requested number exceeds the number of replicas of a certain type specified, no replicas will be deleted.If we tend to remove all TLOG and NRT type replicas (replica types eligible to become leader of shard), the request will not be processed. +If `replica` is used instead, this parameter is not required. Otherwise, this parameter can be supplied with `count` parameter. Review comment: I don't think we need to mention this point. Plus this point quite confuse to me, normally it will be `... this parameter is not required. Otherwise, it must be be specified` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
