dnhatn commented on a change in pull request #1274: LUCENE-9164: Prevent IW
from closing gracefully if threads are still modifying
URL: https://github.com/apache/lucene-solr/pull/1274#discussion_r383443954
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##########
@@ -2417,7 +2424,7 @@ public long deleteAll() throws IOException {
*/
try {
synchronized (fullFlushLock) {
- try (Closeable finalizer = docWriter.lockAndAbortAll()) {
+ try (Closeable finalizer =
acquireModificationLease(docWriter.lockAndAbortAll())) {
Review comment:
Do you have to release locks in the reverse order? Can we have two
try-resources here instead of passing the lock to `acquireModificationLease` ?
If so, we can remove the `in` parameter from `acquireModificationLease`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
