msokolov commented on a change in pull request #1296: LUCENE-9253: Support
custom dictionaries in KoreanTokenizer
URL: https://github.com/apache/lucene-solr/pull/1296#discussion_r386108024
##########
File path:
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/BinaryDictionary.java
##########
@@ -150,7 +150,18 @@ protected final InputStream getResource(String suffix)
throws IOException {
throw new IllegalStateException("unknown resource scheme " +
resourceScheme);
}
}
-
+
+ public static InputStream getResource(ResourceScheme scheme, String path)
throws IOException {
Review comment:
so .. this basically follows the pattern from JapaneseTokenizer, I think. ..
but somehow I don't see where we defined ResourceScheme? We're not referencing
the one in kuromoji, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
