s1monw commented on issue #1274: LUCENE-9164: Prevent IW from closing 
gracefully if threads are still modifying
URL: https://github.com/apache/lucene-solr/pull/1274#issuecomment-594052954
 
 
   > It's scary we are adding yet another synchronization tool to IndexWriter; 
I think we need to add comments to make it clear how it interacts with at least 
IndexWriter's monitor lock (synchronized).
   
   I agree with you. I do wonder if it's worth it. It might be better to go 
back and simplify things (I try for years now) rather than making it more 
complicated.  the change proposed here might be the better solution after all 
https://github.com/apache/lucene-solr/pull/1215
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to