[
https://issues.apache.org/jira/browse/LUCENE-9257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant resolved LUCENE-9257.
------------------------------------
Fix Version/s: 8.6
Resolution: Fixed
Thanks reviewers!
> FSTLoadMode should not be BlockTree specific as it is used more generally in
> index package
> ------------------------------------------------------------------------------------------
>
> Key: LUCENE-9257
> URL: https://issues.apache.org/jira/browse/LUCENE-9257
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Bruno Roustant
> Priority: Minor
> Fix For: 8.6
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> FSTLoadMode and its associate attribute key (static String) are currently
> defined in BlockTreeTermsReader, but they are actually used outside of
> BlockTree in the general "index" package.
> CheckIndex and ReadersAndUpdates are using these enum and attribute key to
> drive the FST load mode through the SegmentReader which is not specific to a
> postings format. They have an unnecessary dependency to BlockTreeTermsReader.
> We could move FSTLoadMode out of BlockTreeTermsReader, to make it a public
> enum of the "index" package. That way CheckIndex and ReadersAndUpdates do not
> import anymore BlockTreeTermsReader.
> This would also allow other postings formats to use the same enum (e.g.
> LUCENE-9254)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
