David Smiley created LUCENE-9277:
------------------------------------

             Summary: UnifiedHighlighter: internally visit the query tree once
                 Key: LUCENE-9277
                 URL: https://issues.apache.org/jira/browse/LUCENE-9277
             Project: Lucene - Core
          Issue Type: Task
          Components: modules/highlighter
            Reporter: David Smiley


Ideally the UnifiedHighlighter should "visit" the query tree *once* instead of 
several times (weight.extractTerms, MultiTermHighlighting, PhraseHelper). 
Perhaps this can happen in one new class, perhaps called QueryExtractor.   It's 
debatable wether this would replace a bunch of fields presently on UHComponents 
or whether it would simply help produce the existing UHComponents; shrug.

Admittedly, I don't know how much of an "optimization" this is, or wether this 
is just a refactoring that is done on principle.  I simply like the principle 
of it; knowing there are multiple _visit_s to the query gnaws at me.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to