dsmiley commented on a change in pull request #1310: SOLR-13350: Multithreaded 
search using collector managers
URL: https://github.com/apache/lucene-solr/pull/1310#discussion_r397859647
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
 ##########
 @@ -1643,6 +1660,83 @@ public ScoreMode scoreMode() {
     qr.setDocList(new DocSlice(0, sliceLen, ids, scores, totalHits, maxScore));
   }
 
+  CollectorManagerResult searchCollectorManagers(int len, QueryCommand cmd, 
Query query,
+      boolean needTopDocs, boolean needMaxScore, boolean needDocSet) throws 
IOException {
+    CollectorManager<MultiCollector, CollectorManagerResult> manager = new 
CollectorManager<MultiCollector, CollectorManagerResult>() {
+      @Override
+      public MultiCollector newCollector() throws IOException {
+        // nocommit: Here, creating a MultiCollector for every segment 
(correctness > speed).
+        // Need to explore sharing a single MultiCollector with every segment. 
Are these
+        // sub-collectors thread-safe? DocSetCollector seems like not 
thread-safe, does someone know?
 
 Review comment:
   DocSetCollector is *not* threadsafe.  That is something Etsy tried to 
tackle.  I think if we had per-segment DocSets (and thus segment oriented 
filter cache), then this would be a non-issue?  I don't think you should tackle 
this in this issue; it's a TODO for another day.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to