dsmiley commented on a change in pull request #1310: SOLR-13350: Multithreaded 
search using collector managers
URL: https://github.com/apache/lucene-solr/pull/1310#discussion_r397828321
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
 ##########
 @@ -353,6 +355,8 @@ public CoreContainer(NodeConfig config, Properties 
properties, CoresLocator loca
         ExecutorUtil.newMDCAwareCachedThreadPool(
             cfg.getReplayUpdatesThreads(),
             new DefaultSolrThreadFactory("replayUpdatesExecutor")));
+    this.collectorExecutor = 
ExecutorUtil.newMDCAwareCachedThreadPool(cfg.getCollectorsPoolSize(),
+        new DefaultSolrThreadFactory("searcherCollectorExecutor"));
 
 Review comment:
   nit: maybe drop "Executor" in the name as it's not an interesting word.  
Shorter thread names.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to