[
https://issues.apache.org/jira/browse/SOLR-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067980#comment-17067980
]
David Smiley commented on SOLR-14351:
-------------------------------------
Your suggestion is complementary and not a different design but an additional
design going beyond what I did.
I'm not sure if it's worth the trouble given it's not a big deal when we mess
this up; not that we don't care but it's not the level of seriousness as
resource-closing / memory-leaks. Things are hard-reset for the next request.
Also, some places, namely HttpSolrCall doesn't balance in a lexical context
with the clear/reset. Granted that case could simply be an exception; your
suggestion doesn't insist on a try-finally always. Shrug, I dunno.
> Harden MDCLoggingContext.clear depth tracking
> ---------------------------------------------
>
> Key: SOLR-14351
> URL: https://issues.apache.org/jira/browse/SOLR-14351
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> MDCLoggingContext tracks recursive calls and only clears when the recursion
> level is back down to 0. If a caller forgets to register and ends up calling
> clear any ways, then this can mess things up. Additionally I found at least
> one place this is occurring, which led me to investigate this matter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
