mbwaheed commented on a change in pull request #1369: SOLR-14213: Allow
enabling shared store to be scriptable
URL: https://github.com/apache/lucene-solr/pull/1369#discussion_r398893770
##########
File path: solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java
##########
@@ -568,4 +568,17 @@ private static PluginInfo
getTracerPluginInfo(XmlConfigFile config) {
Node node = config.getNode("solr/tracerConfig", false);
return (node == null) ? null : new PluginInfo(node, "tracerConfig", false,
true);
}
+
+ private static SharedStoreConfig loadSharedStoreConfig(NamedList<Object> nl)
{
+ if (nl == null) {
+ // shared store is not configured
+ return null;
+ }
+ boolean enabled = Boolean.parseBoolean(
+ required("sharedStore", "sharedStoreEnabled", removeValue(nl,
"sharedStoreEnabled")));
+ if (enabled) {
+ return new SharedStoreConfig();
+ }
Review comment:
Maybe it works for now, but later we might want to properly add an enabled
property to SharedStoreConfig and create SharedStoreConfig even enabled is
false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
