msokolov commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r399829998
########## File path: lucene/core/src/java/org/apache/lucene/search/LongDocValuesPointComparator.java ########## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.search; + +import org.apache.lucene.document.LongPoint; +import org.apache.lucene.index.DocValues; +import org.apache.lucene.index.LeafReaderContext; +import org.apache.lucene.index.NumericDocValues; +import org.apache.lucene.index.PointValues; +import org.apache.lucene.util.DocIdSetBuilder; + +import java.io.IOException; +import java.util.Arrays; + +import static org.apache.lucene.search.FieldComparator.IterableComparator; + +/** + * Expert: a FieldComparator class for long types corresponding to + * {@link LongDocValuesPointSortField}. + * This comparator provides {@code iterator} over competitive documents, + * that are stronger than the current {@code bottom} value. + */ +public class LongDocValuesPointComparator extends IterableComparator<Long> { + private final String field; + private final boolean reverse; + private final long missingValue; + private final long[] values; + private long bottom; + private long topValue; + protected NumericDocValues docValues; + private DocIdSetIterator iterator; + private PointValues pointValues; + private int maxDoc; + private int maxDocVisited; + private int updateCounter = 0; + private byte[] cmaxValueAsBytes = null; Review comment: Can these be final, and allocated only in the constructor? I think it might be clearer to add a boolean "hasTopValues" and set that in setTopValue, rather than use the existence of these byte[]? Then you could make these final and eliminate the local variables where they get copied below ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
